From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedro@codesourcery.com (Pedro Alves)
Cc: gdb-patches@sourceware.org
Subject: Re: Fix foll-fork.exp foll-vfork.exp fork-child-threads.exp
Date: Fri, 21 Nov 2008 01:49:00 -0000 [thread overview]
Message-ID: <200811201636.mAKGawpG029010@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200811201506.04087.pedro@codesourcery.com> from "Pedro Alves" at Nov 20, 2008 03:06:03 PM
Pedro Alves wrote:
> On Thursday 20 November 2008 14:28:24, Ulrich Weigand wrote:
>
> > I guess the "regcache" and "gdbarch" variables now also contain stale
> > information. That's not an actual problem right now, as regcache is
> > (currently) not used after this point, and gdbarch (today) will never
> > actually change -- but in order to reduce potential future problems,
> > I think those should also be reset.
>
> Right, how about the attached?
> 2008-11-20 Pedro Alves <pedro@codesourcery.com>
>
> * infrun.c (resume): If following a fork, also reset regcache,
> gdbarch and pc.
Looks good to me, thanks.
As a separate question, I'm wondering why this is the right place to
put the follow-fork logic anyway (and not in handle_inferior_event
like follow-exec ...). Do you know the history of this?
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2008-11-20 16:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 19:15 Pedro Alves
2008-11-20 23:52 ` Ulrich Weigand
2008-11-21 1:35 ` Pedro Alves
2008-11-21 1:49 ` Ulrich Weigand [this message]
2008-11-21 2:09 ` Pedro Alves
2008-11-21 11:40 ` Ulrich Weigand
2008-11-21 12:58 ` Pedro Alves
2008-12-01 19:01 ` Michael Snyder
2008-12-01 20:56 ` Daniel Jacobowitz
2008-12-01 22:36 ` Michael Snyder
2008-12-01 21:06 ` Pedro Alves
2008-12-01 22:38 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811201636.mAKGawpG029010@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox