From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31773 invoked by alias); 20 Nov 2008 14:43:15 -0000 Received: (qmail 31712 invoked by uid 22791); 20 Nov 2008 14:43:14 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Nov 2008 14:42:34 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 415B810C2E; Thu, 20 Nov 2008 14:42:32 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 1A88310C2C; Thu, 20 Nov 2008 14:42:27 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1L3Aji-0002l3-L9; Thu, 20 Nov 2008 09:42:26 -0500 Date: Fri, 21 Nov 2008 00:46:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] -list-target-groups --available Message-ID: <20081120144226.GA9855@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200811142003.33600.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200811142003.33600.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00557.txt.bz2 On Fri, Nov 14, 2008 at 08:03:33PM +0300, Vladimir Prus wrote: > > This patch implements MI '-list-target-groups --available' -- for > native linux and remote targets. In both cases, the command actually > returns the list of processes. The bulk of the patch was written by > Pedro, I've just added MI bits to it. All the code looks OK to me. However, I would not like to add this patch without testcases or documentation. There should be a DTD somewhere, too. > +void > +_initialize_osdata (void) > +{ > + add_info ("os", info_osdata_command, > + _("Show OS data ARG.")); > + > + /* An alias for "info osdata processes". */ > + add_info ("processes", info_processes_command, > + _("List running processes on the target.")); > +} "info os processes" or "info osdata"? -- Daniel Jacobowitz CodeSourcery