From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6192 invoked by alias); 17 Nov 2008 21:03:06 -0000 Received: (qmail 6131 invoked by uid 22791); 17 Nov 2008 21:03:05 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Nov 2008 21:02:29 +0000 Received: (qmail 1698 invoked from network); 17 Nov 2008 21:02:27 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 17 Nov 2008 21:02:27 -0000 From: Pedro Alves To: "Ulrich Weigand" Subject: Re: [rfc] Fix PR 2250 - multithreaded single-step problems in all-stop mode Date: Tue, 18 Nov 2008 03:36:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org, drow@false.org References: <200811172030.mAHKU54d002481@d12av02.megacenter.de.ibm.com> In-Reply-To: <200811172030.mAHKU54d002481@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200811172102.56650.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00447.txt.bz2 On Monday 17 November 2008 20:30:05, Ulrich Weigand wrote: > In fact other members of the ecs struct should probably be > local variables, maybe some of them passed explicitly to > subroutines. =A0I think this would help simplify understanding > the data-flow along handle_inferior_event and its subroutines ... Agreed, probably, maybe. I few months ago I started doing something like that and got rid of ecs completely, but then I looked at the result and noticed that cutting handle_inferior_event into smaller pieces first (or at the same time) would probably have had better immediate clarity gains, but I didn't try it. That colides a bit (and possibly goes in the opposite direction) with just plain getting rid of ecs, as by doing the lat= ter, you find yourself adjusting callers of callers to pass new flags around (as= opposed to having everything related to an event handy in a single struct). That's= a similar argument to the recent struct value_print_options or replacing current_language with passing a struct around or similars. Anyway, I don't have that much strong feelings in either direction, just telling the world my (possibly bogus) war story. Patches do speak much louder than words. :-) --=20 Pedro Alves