From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3584 invoked by alias); 15 Nov 2008 17:35:06 -0000 Received: (qmail 3561 invoked by uid 22791); 15 Nov 2008 17:35:05 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 15 Nov 2008 17:34:30 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0E10221E4D7; Sat, 15 Nov 2008 12:34:28 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5cdH1MRf7wXo; Sat, 15 Nov 2008 12:34:27 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9233A21E4D1; Sat, 15 Nov 2008 12:34:27 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 60543E7ACD; Sat, 15 Nov 2008 09:34:25 -0800 (PST) Date: Sun, 16 Nov 2008 01:14:00 -0000 From: Joel Brobecker To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Implement -list-thread-groups. Message-ID: <20081115173425.GI12802@adacore.com> References: <200811122333.29218.vladimir@codesourcery.com> <20081114015217.GD12802@adacore.com> <200811142028.43561.vladimir@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200811142028.43561.vladimir@codesourcery.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00391.txt.bz2 > Sorry if I'm trying to circumvent the rules. On the other hand, I > believe I was told that MI boundaries are logical, not physical. In > that sense, a change that clearly matters only for MI, and is actually > posted for comments, is kind of a boundary case. > > Another example are observes. Although generic in nature, they are quickly > becoming de-facto interface of GDB core with MI. I agree there is no absolute rules. But I have to disagree with the observers. Maybe many of them are being used by MI, but several others are not. At AdaCore, we have some local VxWorks ports that we developped which rely on oberver notifications as well. There are still a couple of areas that need polishing, otherwise we'd have submitted this port for inclusion as well. > Done. Indicentally, I know how to configure Emacs to remove trailing > whitespace on save. But pretty much every source file in gdb already > has such lines. If somebody tell me how to make Emacs not add lines > without trailing whitespace, while *not* changing existing lines, it > would be gtreat. Yeah - I try to be careful about not making it worse, but until we have automated style checks at checkin time, I think it's a lost battle. > + If PID is not -1, only prints threads from the process PID. */ ^^^^^^ print Since Michael commented on the following assertion: > + gdb_assert (requested_thead == -1 || pid == -1); ^^^^^ Ooops, typo??? I think it's important to explain it in the function description. Can you add a line or two explaining at the end of the function description explaining that it doesn't make sense to provide both the pid and the thread at the same time, and thus at least one of the two must be set to 1. The rest looks good to me. I don't remember if I pre-approved the patch the previous time I reviewed your patch, so I'll just do it again now. -- Joel