From: Daniel Jacobowitz <drow@false.org>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Make solib-frv.c work in a non-FDPIC environment
Date: Sat, 15 Nov 2008 22:50:00 -0000 [thread overview]
Message-ID: <20081115161443.GB19656@caradoc.them.org> (raw)
In-Reply-To: <20081114162103.05241f81@mesquite.lan>
On Fri, Nov 14, 2008 at 04:21:03PM -0700, Kevin Buettner wrote:
> + if (nsegs < 0)
> + return NULL;
> +
> /* Allocate space for the complete (external) loadmap. */
> ext_ldmbuf_size = sizeof (struct ext_elf32_fdpic_loadmap)
> + (nsegs - 1) * sizeof (struct ext_elf32_fdpic_loadseg);
<= 0? I realize it's probably OK in practice, assuming
ext_elf32_fdpic_loadmap has a trailing [1] array, but allocating less
than the size of the array would be strange.
Otherwise sounds good.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-11-15 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 18:46 Kevin Buettner
2008-11-15 22:50 ` Daniel Jacobowitz [this message]
2008-11-20 2:02 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081115161443.GB19656@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox