From: Daniel Jacobowitz <drow@false.org>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] FRV: Skip call to __main in main()
Date: Sat, 15 Nov 2008 21:13:00 -0000 [thread overview]
Message-ID: <20081115160940.GA19656@caradoc.them.org> (raw)
In-Reply-To: <20081114161353.3495cc1e@mesquite.lan>
On Fri, Nov 14, 2008 at 04:13:53PM -0700, Kevin Buettner wrote:
> For frv-elf (and perhaps other frv targets too), GCC now emits a call
> to __main() in the prologue of main(). The patch below adds code to
> test for this call and to skip over it so that placing a breakpoint in
> main() will correctly cause the breakpoint to be placed on the first
> statement instead of in the prologue.
>
> I submitted a similar patch for PPC a while back and was asked to fix
> the hard-coded constants. However, the convention in frv-tdep.c seems
> to be to use hard-coded constants preceded by a comment block showing
> how the constant was derived. I chose to follow that convention in
> this patch.
No objections here.
Some distant day in the future, I want to convert all of these things
to work on output from libopcodes...
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-11-15 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 18:40 Kevin Buettner
2008-11-15 21:13 ` Daniel Jacobowitz [this message]
2008-11-20 1:58 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081115160940.GA19656@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox