Re: [RFA] -list-target-groups --available

Eli Zaretskii
2008-11-24T21:19:05Z

> Date: Mon, 24 Nov 2008 22:07:19 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: drow@false.org, gdb-patches@sources.redhat.com
>
> > From: Vladimir Prus <vladimir@codesourcery.com>
> > Date: Sat, 22 Nov 2008 19:38:50 +0300
> > Cc: gdb-patches@sources.redhat.com
> >
> > This version has DTD. It also has documentation -- Eli, can you review it.
>
> I will, in a few days.

Actually, it is small enough to review now.

> +@node Operating System Information
> +@appendix Operating System Information
> +@cindex operating system information
> + [...]
> +@node Process list
> +@section Process list

I take it that this last @node is supposed to be a sub-node of
"Operating System Information", right? If so, there are 2 problems
here:

. @appendix is an equivalent of @section, so its immediate sub-nodes
cannot be @section's. They should be @appendixsubsec instead.

. There should be a @menu in the parent @node that lists all its
immediate sub-nodes. Otherwise, makeinfo will barf or do the
wrong thing, because it will not be able to intuit the correct
node structure of the document.

> +Each item is required to include a column with name of @samp{pid},
> +that identifies the process.

"name of `pid'" does not sound right. Do you mean " the name of the
process identified by @var{pid}"?

> + The @samp{user} and @samp{command}
> +columns may be provided

"The @samp{user} and @samp{command} columns are optional..."

> +Target may provide additional columns, but no processing of them
> +is performed by the current version of @value{GDBN}.

Too much passive tense. Suggest to rephrase:

Target may provide additional columns which @value{GDBN} currently
ignores.

Thanks.