From: Joel Brobecker <brobecker@adacore.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Notification for attach/detach.
Date: Fri, 14 Nov 2008 11:19:00 -0000 [thread overview]
Message-ID: <20081113232313.GQ5112@adacore.com> (raw)
In-Reply-To: <200811122335.01950.vladimir@codesourcery.com>
> index f76bf9f..cc0eb06 100644
> --- a/gdb/doc/observer.texi
> +++ b/gdb/doc/observer.texi
> @@ -187,3 +187,13 @@ a pointer to the new architecture.
> The thread's ptid has changed. The @var{old_ptid} parameter specifies
> the old value, and @var{new_ptid} specifies the new value.
> @end deftypefun
> +
> +@deftypefun void new_inferior (int @var{pid})
> +@value{GDBN} has attached to a new inferior identified by @var{pid}.
> +@end deftypefun
> +
> +@deftypefun void inferior_exit (int @var{pid})
> +The inferior identified by @var{pid} has either exited, or was detached
> +from.
> +@end deftypefun
> +
This part should be reviewed by Eli. The documentation for the first
observer looks fine to me, but I find the second one a little awkward.
Perhaps Eli will have another one of his good suggestions. In the
meantime, perhaps the following would do:
The inferior identified by @var{pid} has exited, or @value{GDBN}
detached from it.
> gdb/
> * Makefile.in: Update dependencies.
> * inferior.c: Call the process observers.
> * mi/mi-interp.c (mi_new_inferior, mi_inferior_exit): New.
> (mi_interpreter_init): Register the above.
As spotted by Tom, the Makefile.in entry needs to be removed.
The inferior.c part looks good to me. As for the mi changes,
I looked at them and I didn't see anything wrong, but you are
the maintainer and you know way more about this part than I do,
so you don't need my approval.
> gdb/doc/
> * observer.texi (new_inferior, inferior_exit): New observers.
--
Joel
next prev parent reply other threads:[~2008-11-13 23:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 21:07 Vladimir Prus
2008-11-13 1:17 ` Tom Tromey
2008-11-13 1:29 ` Vladimir Prus
2008-11-14 11:19 ` Joel Brobecker [this message]
2008-11-14 19:19 ` Vladimir Prus
2008-11-14 23:14 ` Eli Zaretskii
2008-11-14 23:25 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113232313.GQ5112@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox