Re: [RFA] Kill ptrace_ops_hack

Thiago Jung Bauermann
2008-11-11T22:10:47Z

Hi,

El mar, 04-11-2008 a las 13:19 +0300, Vladimir Prus escribiÃ³:
> * target.h (struct target_ops): Make to_attach, to_detach,
> to_create_inferior and to_mourn_inferior accept a pointer
> to struct target_ops.

This patch missed functions in remote-sim.c, giving the following
warning with GCC 4.1.2:

cc1: warnings being treated as errors
/home/bauermann/scratchpad/python/gdb.git/gdb/remote-sim.c: In function ‘init_gdbsim_ops’:
/home/bauermann/scratchpad/python/gdb.git/gdb/remote-sim.c:918: warning: assignment from incompatible pointer type
/home/bauermann/scratchpad/python/gdb.git/gdb/remote-sim.c:919: warning: assignment from incompatible pointer type

GCC 4.3.2 doesn't complain, though.

Committed the following as obvious.
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center

2008-11-11 Thiago Jung Bauermann <bauerman@br.ibm.com>

* remote-sim.c (gdbsim_create_inferior, gdbsim_mourn_inferior): Add
missing struct target_ops argument.

Index: gdb.git/gdb/remote-sim.c
===================================================================
--- gdb.git.orig/gdb/remote-sim.c 2008-11-11 10:29:32.000000000 -0800
+++ gdb.git/gdb/remote-sim.c 2008-11-11 13:57:51.000000000 -0800
@@ -94,7 +94,7 @@

static void gdbsim_files_info (struct target_ops *target);

-static void gdbsim_mourn_inferior (void);
+static void gdbsim_mourn_inferior (struct target_ops *target);

static void gdbsim_stop (ptid_t ptid);

@@ -445,7 +445,8 @@
user types "run" after having attached. */

static void
-gdbsim_create_inferior (char *exec_file, char *args, char **env, int from_tty)
+gdbsim_create_inferior (struct target_ops *target, char *exec_file, char *args,
+ char **env, int from_tty)
{
int len;
char *arg_buf, **argv;
@@ -822,7 +823,7 @@
/* Clear the simulator's notion of what the break points are. */

static void
-gdbsim_mourn_inferior (void)
+gdbsim_mourn_inferior (struct target_ops *target)
{
if (remote_debug)
printf_filtered ("gdbsim_mourn_inferior:\n");