Re: [RFA] Kill ptrace_ops_hack

Joel Brobecker
2008-11-13T01:29:32Z

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

> As it happens, I had approved a patch that fixes exactly this,
> but that didn't get checked in:
>
> http://www.sourceware.org/ml/gdb-patches/2008-11/msg00175.html
>
> The patch is slightly more complete as it removes one reference to
> the gdbsim_ops global. I'll commit that part separately.

Humpf, in retrospect, I find that the above sounds very ungrateful.
Sorry about that, Thiago. I am in fact pleased that you fixed the
problem this fast!

I committed the following piece. It's really only very very minor,
but it still makes the code slightly cleaner, I think.

2008-11-12 Joel Brobecker <brobecker@adacore.com>

From Joel Sherrill <joel.sherrill@oarcorp.com>
* remote-sim.c (gdbsim_mourn_inferior): Use "target" parameter
instead of the "gdbsim_ops" global.

Checked in.

--
Joel

[-- Attachment #2: remote-sim.c.diff --]
[-- Type: text/plain, Size: 564 bytes --]

Index: remote-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sim.c,v
retrieving revision 1.79
diff -u -p -r1.79 remote-sim.c
--- remote-sim.c 11 Nov 2008 22:07:40 -0000 1.79
+++ remote-sim.c 13 Nov 2008 01:23:12 -0000
@@ -829,7 +829,7 @@ gdbsim_mourn_inferior (struct target_ops
printf_filtered ("gdbsim_mourn_inferior:\n");

remove_breakpoints ();
- target_mark_exited (&gdbsim_ops);
+ target_mark_exited (target);
generic_mourn_inferior ();
delete_thread_silent (remote_sim_ptid);
}