From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5738 invoked by alias); 4 Nov 2008 15:13:15 -0000 Received: (qmail 5639 invoked by uid 22791); 4 Nov 2008 15:13:14 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Nov 2008 15:12:33 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id A13FC10CE2; Tue, 4 Nov 2008 15:12:30 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 89CCE10C35; Tue, 4 Nov 2008 15:12:30 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KxNa1-0000RJ-Uh; Tue, 04 Nov 2008 10:12:29 -0500 Date: Tue, 04 Nov 2008 15:13:00 -0000 From: Daniel Jacobowitz To: =?iso-8859-1?Q?S=E9rgio_Durigan_J=FAnior?= Cc: Mark Kettenis , gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] 'catch syscall' feature -- XML support part Message-ID: <20081104151229.GA32619@caradoc.them.org> Mail-Followup-To: =?iso-8859-1?Q?S=E9rgio_Durigan_J=FAnior?= , Mark Kettenis , gdb-patches@sourceware.org References: <1225773086.24532.55.camel@miki> <200811041335.mA4DZtYH016463@brahms.sibelius.xs4all.nl> <20081104134708.GA10644@caradoc.them.org> <1225811056.32321.9.camel@miki> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1225811056.32321.9.camel@miki> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00030.txt.bz2 On Tue, Nov 04, 2008 at 01:04:16PM -0200, Sérgio Durigan Júnior wrote: > Hi Daniel, > > On Tue, 2008-11-04 at 08:47 -0500, Daniel Jacobowitz wrote: > > On Tue, Nov 04, 2008 at 02:35:55PM +0100, Mark Kettenis wrote: > > > Hmm, I haven't looked at the code yes, but this is all Linux-specific > > > stuff, so this should be reflected in the names of those files. > > > > Yes please. We should be able to do non-Linux syscalls too, but > > they'll require different data files. > > > > Sergio, while you're moving them, could they go in a subdirectory > > please? Maybe gdb/syscalls/ ? It doesn't need to have a separate > > ChangeLog or Makefile or anything like that. > > IIUC, you're asking me to put the XML files in gdb/syscalls/ right? > Well, they are already there :-). I think the correct approach to solve > this problem is renaming the XML files to something like > "i386-linux-syscalls.xml", isn't it? Oh whoops - then since the ChangeLog is in gdb/ChangeLog, the entry should refer to "syscalls/i386-syscalls.xml" instead of just "i386-syscalls.xml". How about renaming to "syscalls/i386-linux.xml"? -- Daniel Jacobowitz CodeSourcery