Re: [PATCH 3/4] 'catch syscall' feature -- XML support part

Daniel Jacobowitz
2008-11-04T15:13:15Z

On Tue, Nov 04, 2008 at 01:04:16PM -0200, SÃ©rgio Durigan JÃºnior wrote:
> Hi Daniel,
>
> On Tue, 2008-11-04 at 08:47 -0500, Daniel Jacobowitz wrote:
> > On Tue, Nov 04, 2008 at 02:35:55PM +0100, Mark Kettenis wrote:
> > > Hmm, I haven't looked at the code yes, but this is all Linux-specific
> > > stuff, so this should be reflected in the names of those files.
> >
> > Yes please. We should be able to do non-Linux syscalls too, but
> > they'll require different data files.
> >
> > Sergio, while you're moving them, could they go in a subdirectory
> > please? Maybe gdb/syscalls/ ? It doesn't need to have a separate
> > ChangeLog or Makefile or anything like that.
>
> IIUC, you're asking me to put the XML files in gdb/syscalls/ right?
> Well, they are already there :-). I think the correct approach to solve
> this problem is renaming the XML files to something like
> "i386-linux-syscalls.xml", isn't it?

Oh whoops - then since the ChangeLog is in gdb/ChangeLog, the entry
should refer to "syscalls/i386-syscalls.xml" instead of just
"i386-syscalls.xml". How about renaming to "syscalls/i386-linux.xml"?

--
Daniel Jacobowitz
CodeSourcery