From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14418 invoked by alias); 30 Oct 2008 03:01:56 -0000 Received: (qmail 14408 invoked by uid 22791); 30 Oct 2008 03:01:55 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 30 Oct 2008 03:01:51 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8F15F2A96C7; Wed, 29 Oct 2008 23:01:49 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 9+VspRO937-a; Wed, 29 Oct 2008 23:01:49 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 562D82A96C2; Wed, 29 Oct 2008 23:01:49 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 40D7DE7ACD; Wed, 29 Oct 2008 20:01:47 -0700 (PDT) Date: Thu, 30 Oct 2008 03:08:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org, Doug Evans Subject: Re: [RFA] Move -nx from GDBFLAGS to INTERNAL_GDBFLAGS in testsuite Message-ID: <20081030030147.GB3635@adacore.com> References: <20081021190500.BB7251C7954@localhost> <200810271252.35628.pedro@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200810271252.35628.pedro@codesourcery.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00696.txt.bz2 > I like the idea of this patch. I tend to use "set GDBFLAGS foo" in > my boardfiles myself. > > What do others think of it? Seems like a good idea to me as well. That's consistent with what we do in the Makefile, I believe. > > +# INTERNAL_GDBFLAGS contains flags that the testsuite requires. > > +# ??? Perhaps -nw should go here too. Dunno. > > Personally, I'd decide/chose one, and remove this comment. If > you leave it in, we're doomed to stare and be annoyed by > it forever. :-) I would put the -nw in INTERNAL_GDBCFLAGS as well. Except maybe for the doing some TUI-specific testing, I don't see us testing the debugger in graphical mode. -- Joel