From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5556 invoked by alias); 25 Oct 2008 16:10:26 -0000 Received: (qmail 5545 invoked by uid 22791); 25 Oct 2008 16:10:24 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 25 Oct 2008 16:09:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A37C22A9662; Sat, 25 Oct 2008 12:09:47 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id v7rItDqWDIuR; Sat, 25 Oct 2008 12:09:47 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 573102A9659; Sat, 25 Oct 2008 12:09:47 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1B03FE7ACD; Sat, 25 Oct 2008 09:09:45 -0700 (PDT) Date: Sat, 25 Oct 2008 16:10:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" , teawater Subject: Re: [RFA] Handle runtime loader dyn sym resolution in reverse Message-ID: <20081025160945.GI29998@adacore.com> References: <49028B5C.2000508@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49028B5C.2000508@vmware.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00642.txt.bz2 > This is for both the main trunk and the record/replay branch > (so I'd appreciate review by both Hui and a global maintainer). I took a look. The patch itself is missing a little bit of context (in terms of the code), so I wasn't sure whether I was looking at inserting this hunk at the right place, but I think I found it: if (ecs->event_thread->step_over_calls == STEP_OVER_ALL) { /* We're doing a "next". Normal (forward) execution: set a breakpoint at the callee's return address (the address at which the caller will resume). Reverse (backward) execution. set the step-resume breakpoint at the start of the function that we just stepped into (backwards), and continue to there. When we get there, we'll need to single-step back to the caller. */ if (execution_direction == EXEC_REVERSE) > 2008-10-24 Michael Snyder > > * infrun.c (handle_inferior_event): Handle dynamic symbol > resolution in reverse. Looks OK to me, but I don't understand why you check that stop_func_start is zero. If I were to make a guess, it would be to quickly dismiss the case were we reverse stepped into a function call, and so don't need to check for trampolines (in other words, a CPU saver). -- Joel