Re: A couple of uses of xmalloc and xfree in a couple of .y files

Pedro Alves
2008-10-25T02:37:23Z

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

On Saturday 25 October 2008 01:13:50, Joel Brobecker wrote:
> > Anything I'm missing preventing me from applying this as obvious?
>
> Yes, I think we should be consistent.

Thanks for confirming. I've checked it in.

On Saturday 25 October 2008 02:58:05, Daniel Jacobowitz wrote:
> On Fri, Oct 24, 2008 at 05:13:50PM -0700, Joel Brobecker wrote:
> > The thing I don't get is why we don't translate free->xfree, though.
>
> I think the sed rule predates our copy of xfree.

Yeah, from the ChangeLogs it seems so.

Also, free is a word that easilly can appear anywhere. Most notably:

"This program is xfree software" :-)

Don't think it matters anywhere else, though.

We also have have things like,

obstack_free

The attached seems to work OK in all cases here.

Do we want this ?

--
Pedro Alves

[-- Attachment #2: trans_xfree.diff --]
[-- Type: text/x-diff, Size: 1111 bytes --]

2008-10-25 Pedro Alves <pedro@codesourcery.com>

* Makefile.in (.y.c, .l.c): sed free to xfree.

---
gdb/Makefile.in | 4 ++++
1 file changed, 4 insertions(+)

Index: src/gdb/Makefile.in
===================================================================
--- src.orig/gdb/Makefile.in 2008-10-25 03:14:41.000000000 +0100
+++ src/gdb/Makefile.in 2008-10-25 03:26:34.000000000 +0100
@@ -1470,6 +1470,8 @@ po/$(PACKAGE).pot: force
-e '/include.*malloc.h/d' \
-e 's/\([^x]\)malloc/\1xmalloc/g' \
-e 's/\([^x]\)realloc/\1xrealloc/g' \
+ -e 's/\([ \t;,(]\)free\([ \t]*[&(),]\)/\1xfree\2/g' \
+ -e 's/\([ \t;,(]\)free$$/\1xfree/g' \
-e '/^#line.*y.tab.c/d' \
< $@.tmp > $@.new
-rm $@.tmp
@@ -1484,6 +1486,8 @@ po/$(PACKAGE).pot: force
-e '/include.*malloc.h/d' \
-e 's/\([^x]\)malloc/\1xmalloc/g' \
-e 's/\([^x]\)realloc/\1xrealloc/g' \
+ -e 's/\([ \t;,(]\)free\([ \t]*[&(),]\)/\1xfree\2/g' \
+ -e 's/\([ \t;,(]\)free$$/\1xfree/g' \
-e 's/yy_flex_xrealloc/yyxrealloc/g' \
< $@ > $@.new && \
rm -f $@ && \