From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23928 invoked by alias); 25 Oct 2008 00:14:30 -0000 Received: (qmail 23920 invoked by uid 22791); 25 Oct 2008 00:14:29 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 25 Oct 2008 00:13:54 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 95EB42A9668; Fri, 24 Oct 2008 20:13:52 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NYg03dsCpbjc; Fri, 24 Oct 2008 20:13:52 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 62AD62A966A; Fri, 24 Oct 2008 20:13:52 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 86DFDE7ACD; Fri, 24 Oct 2008 17:13:50 -0700 (PDT) Date: Sat, 25 Oct 2008 00:14:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: A couple of uses of xmalloc and xfree in a couple of .y files Message-ID: <20081025001350.GC29998@adacore.com> References: <200810242358.11089.pedro@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200810242358.11089.pedro@codesourcery.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00625.txt.bz2 > Anything I'm missing preventing me from applying this as obvious? Yes, I think we should be consistent. The thing I don't get is why we don't translate free->xfree, though. > 2008-10-24 Pedro Alves > > * ada-exp.y (write_object_renaming): Use malloc instead of > xmalloc. > * p-exp.y (pop_current_type): Use free instead of xfree. -- Joel