From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org, tromey@redhat.com,
Thiago Jung Bauermann <bauerman@br.ibm.com>
Subject: Fix python-value.exp for stubs
Date: Fri, 24 Oct 2008 18:30:00 -0000 [thread overview]
Message-ID: <200810241930.01181.pedro@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]
I've noticed these failures when testing against a local gdbserver.
Using ../../../src/gdb/testsuite/config/gdbserver.exp as tool-and-target-specific interface file.
Running ../../../src/gdb/testsuite/gdb.python/python-value.exp ...
FAIL: gdb.python/python-value.exp: continue to breakpoint: break to inspect struct and union
FAIL: gdb.python/python-value.exp: print s
FAIL: gdb.python/python-value.exp: access element inside struct using 8-bit string name
FAIL: gdb.python/python-value.exp: access element inside struct using unicode name
FAIL: gdb.python/python-value.exp: print argv
FAIL: gdb.python/python-value.exp: dereference value
FAIL: gdb.python/python-value.exp: verify dereferenced value
The issue here is the usage of gdb_start_cmd, which is a nop against stubs.
The attached fixes it here for me, both gdbserver, and native linux.
The race mentioned in the test seems to be related to the fact that gdb_start_cmd
doesn't wait for "main" to be reached at all. The attached patch should get
rid of the need to work around that.
Tromey, Bauermann, OK to apply this?
--
Pedro Alves
[-- Attachment #2: python_remote.diff --]
[-- Type: text/x-diff, Size: 1233 bytes --]
2008-10-24 Pedro Alves <pedro@codesourcery.com>
* gdb.python/python-value.exp (test_value_in_inferior): Don't use
gdb_start_cmd.
Use runto_main before any test that requires execution.
---
gdb/testsuite/gdb.python/python-value.exp | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
Index: src/gdb/testsuite/gdb.python/python-value.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.python/python-value.exp 2008-10-24 19:22:59.000000000 +0100
+++ src/gdb/testsuite/gdb.python/python-value.exp 2008-10-24 19:24:05.000000000 +0100
@@ -199,11 +199,6 @@ proc test_value_in_inferior {} {
global testfile
gdb_breakpoint [gdb_get_line_number "break to inspect struct and union"]
- gdb_start_cmd
-
- # Avoid race condition where a continue command in gdb_continue_to_breakpoint
- # is issued too early.
- gdb_test "" "$gdb_prompt"
gdb_continue_to_breakpoint "break to inspect struct and union"
@@ -247,4 +242,12 @@ test_value_creation
test_value_numeric_ops
test_value_boolean
test_value_compare
+
+# The following tests require execution.
+
+if ![runto_main] then {
+ fail "Can't run to main"
+ return 0
+}
+
test_value_in_inferior
next reply other threads:[~2008-10-24 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 18:30 Pedro Alves [this message]
2008-10-24 18:44 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810241930.01181.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox