From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30320 invoked by alias); 24 Oct 2008 18:48:01 -0000 Received: (qmail 30299 invoked by uid 22791); 24 Oct 2008 18:48:01 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Oct 2008 18:47:21 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id C65F810812; Fri, 24 Oct 2008 18:47:19 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id AC1E7106D8; Fri, 24 Oct 2008 18:47:19 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KtRgt-0002Cm-C5; Fri, 24 Oct 2008 14:47:19 -0400 Date: Fri, 24 Oct 2008 18:48:00 -0000 From: Daniel Jacobowitz To: Doug Evans , gdb-patches@sourceware.org Subject: Re: [commit] dwarf2read.c (typename_concat): avoid segv Message-ID: <20081024184719.GA8460@caradoc.them.org> Mail-Followup-To: Doug Evans , gdb-patches@sourceware.org References: <20081024182614.58B191C7947@localhost> <20081024184301.GA7759@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081024184301.GA7759@caradoc.them.org> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00613.txt.bz2 On Fri, Oct 24, 2008 at 02:43:01PM -0400, Daniel Jacobowitz wrote: > If NULL values are valid, this change is definitely not correct. > You've changed a NULL prefix and "foo" suffix from "foo" to "::foo". "Definitely" is too strong... I see that we differed with and without an obstack :-( -- Daniel Jacobowitz CodeSourcery