From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21682 invoked by alias); 24 Oct 2008 13:01:21 -0000 Received: (qmail 21673 invoked by uid 22791); 24 Oct 2008 13:01:21 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Oct 2008 13:00:37 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m9OD0YJn392966 for ; Fri, 24 Oct 2008 13:00:34 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9OD0YIb3629150 for ; Fri, 24 Oct 2008 15:00:34 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9OD0XJH010767 for ; Fri, 24 Oct 2008 15:00:33 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m9OD0X69010748; Fri, 24 Oct 2008 15:00:33 +0200 Message-Id: <200810241300.m9OD0X69010748@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 24 Oct 2008 15:00:33 +0200 Subject: Re: [RFC/RFA] add struct parse_context to all command functions To: tromey@redhat.com Date: Fri, 24 Oct 2008 13:01:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), gdb-patches@sourceware.org In-Reply-To: from "Tom Tromey" at Oct 23, 2008 03:26:44 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00606.txt.bz2 Tom Tromey wrote: > Thanks. The appended tries to fix this. I took a behavior-preserving > approach. I looked at all the val_print-like calls. If the code > before the patch passed 'deref_ref' to such a call, I ignored it. > Otherwise I made a copy of the options and set deref_ref > appropriately. > > In some cases I suspect the previous code is really a "don't care" and > we could just pass through the options. But, I think that would be > better done by someone more familiar with each call site than I am. Agreed. > I'll start testing this and writing the ChangeLog entry. Thanks! The patch looks good to me now, so if testing goes well, this is OK. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com