From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21594 invoked by alias); 22 Oct 2008 20:36:31 -0000 Received: (qmail 21585 invoked by uid 22791); 22 Oct 2008 20:36:31 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Oct 2008 20:35:56 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 24B942A966A; Wed, 22 Oct 2008 16:35:54 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Q-JjX9ROaeCX; Wed, 22 Oct 2008 16:35:54 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3C8BC2A9668; Wed, 22 Oct 2008 16:35:52 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 95581E7AD0; Wed, 22 Oct 2008 13:35:46 -0700 (PDT) Date: Wed, 22 Oct 2008 20:36:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Ulrich Weigand , Thiago Jung Bauermann , gdb-patches@sourceware.org Subject: Re: [RFC/RFA] add struct parse_context to all command functions Message-ID: <20081022203546.GH3638@adacore.com> References: <20081021004630.GA6571@caradoc.them.org> <200810211805.m9LI5Lt0014410@d12av02.megacenter.de.ibm.com> <20081021181739.GA10391@caradoc.them.org> <20081022014000.GA3638@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00558.txt.bz2 > I still think the benefits are mild, at best, but I don't want to stop > your gusto. I don't think this change will make gdb worse. Well, if I read other's temperature well, it seems to me that I might be the only one convinced that this is a good change. This is usually an indicator that the idea might not be as obviously good as I think. Since this is a pretty labour-intensive change, I'm now thinking that, short of more support, I should just enhance the parse routines to take a parse_context structure as a parameter rather than using the globals, and leave the rest of GDB alone. -- Joel