From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24448 invoked by alias); 21 Oct 2008 18:05:39 -0000 Received: (qmail 24424 invoked by uid 22791); 21 Oct 2008 18:05:38 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 21 Oct 2008 18:04:45 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id m9LI4I3H182048 for ; Tue, 21 Oct 2008 18:04:18 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9LI4IXK3109034 for ; Tue, 21 Oct 2008 20:04:18 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9LI4IAi013113 for ; Tue, 21 Oct 2008 20:04:18 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m9LI4IBr013110; Tue, 21 Oct 2008 20:04:18 +0200 Message-Id: <200810211804.m9LI4IBr013110@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 21 Oct 2008 20:04:18 +0200 Subject: Re: [RFC/RFA] add struct parse_context to all command functions To: brobecker@adacore.com (Joel Brobecker) Date: Tue, 21 Oct 2008 18:05:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20081009140424.GD5372@adacore.com> from "Joel Brobecker" at Oct 09, 2008 10:04:24 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00509.txt.bz2 Joel Brobecker wrote: > I'd like to start working on adding a struct parse_context again. > The ultimate goal is to pass this structure as an argument to all > the "parse..." routines, rather than rely on the current_language > and input_radix globals. In addition to being cleaner, it will also > help fix a bug where the current_language is switched under us while > trying to do parse an expression. Now that current_gdbarch is already pulled out of the parse routines, it would make sense to also add a gdbarch parameter to the parse_context structure; this would be used to set up expout->gdbarch in parse_exp_in_context. Otherwise, I like the proposal :-) Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com