From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25703 invoked by alias); 16 Oct 2008 02:39:21 -0000 Received: (qmail 25694 invoked by uid 22791); 16 Oct 2008 02:39:20 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 16 Oct 2008 02:38:41 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7B50A10879; Thu, 16 Oct 2008 02:38:38 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 0EFA210815; Thu, 16 Oct 2008 02:38:38 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KqIl3-0008VE-Bu; Wed, 15 Oct 2008 22:38:37 -0400 Date: Thu, 16 Oct 2008 02:39:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: teawater , Eli Zaretskii , gdb-patches@sourceware.org, Joel Brobecker , Michael Snyder Subject: Re: [RFA] Displaced stepping just enable in non-stop mode Message-ID: <20081016023837.GA32668@caradoc.them.org> Mail-Followup-To: Pedro Alves , teawater , Eli Zaretskii , gdb-patches@sourceware.org, Joel Brobecker , Michael Snyder References: <200810160107.42525.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200810160107.42525.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00390.txt.bz2 On Thu, Oct 16, 2008 at 01:07:42AM +0100, Pedro Alves wrote: > Hi teawater, > > Thanks again for doing this. I believe your patch is close to being OK. I > took the liberty of adjusting it a bit, mostly re-wording a bit the > comments and the documentation. > > I think Joel's suggestion was a good one: By gaining an "auto" > setting, this is as much a maintainer command as > "set breakpoint always-inserted" is. So, I believe it's time we move > the command to the top level "set" command group. > > set can-use-displaced-stepping (auto|on|off) > > Eli, can I ask you to go over the help strings and the documentation in > the patch below? Do they look OK-ish? That's a pretty long name. Do you think there are any other useful stepping related settings? If so, maybe we should have a "set step" prefix. -- Daniel Jacobowitz CodeSourcery