From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6623 invoked by alias); 8 Oct 2008 12:54:55 -0000 Received: (qmail 6613 invoked by uid 22791); 8 Oct 2008 12:54:54 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 08 Oct 2008 12:54:04 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m98CqSOi015114; Wed, 8 Oct 2008 08:52:50 -0400 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m98CqRMT005798; Wed, 8 Oct 2008 08:52:27 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.stuttgart.redhat.com (8.13.1/8.13.1) with ESMTP id m98CqP3W001151; Wed, 8 Oct 2008 08:52:26 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.2) with ESMTP id m98CqOuU023299; Wed, 8 Oct 2008 14:52:24 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id m98CqNTh023293; Wed, 8 Oct 2008 14:52:23 +0200 Date: Wed, 08 Oct 2008 12:54:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org, Tobias Burnus , Ulrich Weigand , Jim Blandy Subject: Re: [patch] static_kind -> bit0, bit1 [Re: [gdb] Fortran dynamic arrays] Message-ID: <20081008125223.GA18537@host0.dyn.jankratochvil.net> References: <20080818111120.GE16894@adacore.com> <200808181553.m7IFrG3w005270@d12av02.megacenter.de.ibm.com> <48A59B3C.9050801@net-b.de> <20080818111120.GE16894@adacore.com> <20080907115637.GA12939@host0.dyn.jankratochvil.net> <20080919221221.GA23372@adacore.com> <20081004202457.GA20726@host0.dyn.jankratochvil.net> <20081006200001.GC3588@adacore.com> <20081007225538.GA1206@host0.dyn.jankratochvil.net> <20081008032731.GE3810@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081008032731.GE3810@adacore.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00248.txt.bz2 On Wed, 08 Oct 2008 05:27:31 +0200, Joel Brobecker wrote: > [in copy_type_recursive] > > + break; > > + default: > > + gdb_assert (0); > > Can you change that to using an internal_error, instead? For instance, > > internal_error (__FILE__, __LINE__, _("Unexpected ... kind: %d"), > TYPE_FIELD_LOC_KIND (type, i)); > > Something like that. Used: + internal_error (__FILE__, __LINE__, + _("Unexpected type field location kind: %d"), + TYPE_FIELD_LOC_KIND (type, i)); And committed: http://sourceware.org/ml/gdb-cvs/2008-10/msg00099.html Going to post the real parts of the patchset rebased on this change and split. Thanks, Jan