From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15580 invoked by alias); 8 Oct 2008 00:16:23 -0000 Received: (qmail 15572 invoked by uid 22791); 8 Oct 2008 00:16:23 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 08 Oct 2008 00:15:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 15A9D2A96F1; Tue, 7 Oct 2008 20:15:46 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GMhPd2UrQ01t; Tue, 7 Oct 2008 20:15:46 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D29D72A96F6; Tue, 7 Oct 2008 20:15:44 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 008BCE7ACD; Tue, 7 Oct 2008 20:15:41 -0400 (EDT) Date: Wed, 08 Oct 2008 00:16:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" , Pedro Alves , teawater Subject: Re: [RFA] Reverse Debugging, 1/5 Message-ID: <20081008001541.GA3810@adacore.com> References: <20081006203021.GA21853@adacore.com> <48EA7C75.7070703@vmware.com> <20081006211131.GA26663@caradoc.them.org> <48EA8065.9070001@vmware.com> <20081006212504.GB31085@caradoc.them.org> <48EA868E.3070404@vmware.com> <20081006222258.GF21853@adacore.com> <48EAB0AD.30906@vmware.com> <20081007034840.GE28138@adacore.com> <48EBAA24.2080700@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48EBAA24.2080700@vmware.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00229.txt.bz2 > >My own view was a little simpler: Delete the target_set_execdir method, > > I'm guessing you meant "get" here? Ooops! yes, that' right. > > >and replace all the calls with a reference to the infrun global. I would > >keep the target_set_execdir more or less as is; otherwise, you'll need > >some kind of observer to notice when the execdir changes. The > >"to_can_go_backwards" is an interesting idea, but in my opinion only > >makes sense if the target_set_execdir method is removed. Otherwise, > >we can treat target_set_execdir == NULL as cannot-go-backwards. > > OK, so you're saying that "target_set_execdir" will set the > global infrun variable, not a target-defined variable? Not quite, actually. Roughly, when the user changes the exec direction, we call target_set_execdir and, if the call succeeded, then update the direction known in infrun. Or perhaps you or others have better ideas? -- Joel