From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29124 invoked by alias); 7 Oct 2008 23:22:15 -0000 Received: (qmail 29116 invoked by uid 22791); 7 Oct 2008 23:22:14 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 07 Oct 2008 23:21:39 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m97NLGj9015623; Tue, 7 Oct 2008 19:21:16 -0400 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m97NLEvX020737; Tue, 7 Oct 2008 19:21:14 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.stuttgart.redhat.com (8.13.1/8.13.1) with ESMTP id m97NLCSZ020321; Tue, 7 Oct 2008 19:21:13 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.2) with ESMTP id m97NLC7x007186; Wed, 8 Oct 2008 01:21:12 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id m97NLBVv007183; Wed, 8 Oct 2008 01:21:11 +0200 Date: Tue, 07 Oct 2008 23:22:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org, Daniel Jacobowitz , Tom Tromey Subject: type/main_type/field size [Re: [patch] static_kind -> bit0, bit1] Message-ID: <20081007232111.GA6913@host0.dyn.jankratochvil.net> References: <20080818111120.GE16894@adacore.com> <200808181553.m7IFrG3w005270@d12av02.megacenter.de.ibm.com> <48A59B3C.9050801@net-b.de> <20080818111120.GE16894@adacore.com> <20080907115637.GA12939@host0.dyn.jankratochvil.net> <20080919221221.GA23372@adacore.com> <20080926125754.GC21287@caradoc.them.org> <20081006200928.GD3588@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3uo+9/B/ebqu+fSQ" Content-Disposition: inline In-Reply-To: <20081006200928.GD3588@adacore.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00228.txt.bz2 --3uo+9/B/ebqu+fSQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 929 On Mon, 06 Oct 2008 22:09:28 +0200, Joel Brobecker wrote: > I think it is kind of ugly, and i tried to think about it for a while, > but I don't see many possible solutions if we don't want to increase > the gdbtype struct size. BTW are there some measurements if sizeof (type / main_type / field) matters? On Tue, 07 Oct 2008 19:48:53 +0200, Tom Tromey wrote: > For the lazy psymtab thing I had two related test cases: > > 1. Start OO.o writer, then time 'attach'. > 2. The same, plus time "thread apply all bt full". FYI I found (on Firefox) the difference of reading full symbols for this command `thread apply all bt full' is: valgrind --tool=massif: mem_heap_B=393798138 mem_heap_B=395820353 == 2MB == only 0.5% size increase (by the attached patch if it is right) Just `thread apply all bt full' may not be the typical debugging session, a more representative application / command set would be useful. Regards, Jan --3uo+9/B/ebqu+fSQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="gdb-readneverfull.patch" Content-length: 706 --- gdb/dwarf2read.c 30 Sep 2008 16:57:37 -0000 1.285 +++ gdb/dwarf2read.c 7 Oct 2008 20:50:07 -0000 @@ -2432,6 +2432,7 @@ locate_pdi_sibling (struct partial_die_i static void dwarf2_psymtab_to_symtab (struct partial_symtab *pst) { +return; /* FIXME: This is barely more than a stub. */ if (pst != NULL) { --- gdb/symtab.c 1 Oct 2008 17:25:22 -0000 1.199 +++ gdb/symtab.c 7 Oct 2008 20:50:10 -0000 @@ -1527,6 +1527,8 @@ lookup_symbol_aux_psymtabs (int block_in psymtab_index, domain)) { s = PSYMTAB_TO_SYMTAB (ps); + if (!s) + continue; bv = BLOCKVECTOR (s); block = BLOCKVECTOR_BLOCK (bv, block_index); sym = lookup_block_symbol (block, name, linkage_name, domain); --3uo+9/B/ebqu+fSQ--