From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18155 invoked by alias); 7 Oct 2008 03:30:33 -0000 Received: (qmail 18147 invoked by uid 22791); 7 Oct 2008 03:30:33 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 07 Oct 2008 03:29:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 53E3B2A96AE; Mon, 6 Oct 2008 23:29:56 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mT+EOO1HP6ii; Mon, 6 Oct 2008 23:29:56 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E177B2A96A9; Mon, 6 Oct 2008 23:29:55 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8DDA8E7ACD; Mon, 6 Oct 2008 20:29:55 -0700 (PDT) Date: Tue, 07 Oct 2008 03:30:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" , Daniel Jacobowitz , Pedro Alves , teawater Subject: Re: [RFA] Reverse Debugging, 5/5 Message-ID: <20081007032955.GC28138@adacore.com> References: <48E3CD66.9020600@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48E3CD66.9020600@vmware.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00198.txt.bz2 I think that the implementation of this file will change slightly based on the outcome of some of the discussions we had with the previous patch. But I noticed a few little things in addition to what Eli already said. > + Copyright (C) 2006 Free Software Foundation, Inc. The copyright date should include 2008. > + (returns error unles target implements to_set_execdir method). */ ^^^^^ unless > +static void > +exec_reverse_once (char *cmd, char *args, int from_tty) This function needs a comment describing what it does. I was almost at the end of the function before I understood its purpose. > + add_setshow_enum_cmd ("exec-direction", class_run, exec_direction_names, > + &exec_direction, "Set direction of execution.\n\ > +Options are 'forward' or 'reverse'.", > + "Show direction of execution (forward/reverse).", > + "Tells gdb whether to execute forward or backward.", > + set_exec_direction_func, show_exec_direction_func, > + &setlist, &showlist); Minor nit: i18n. -- Joel