From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10658 invoked by alias); 7 Oct 2008 03:15:03 -0000 Received: (qmail 10624 invoked by uid 22791); 7 Oct 2008 03:15:02 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 07 Oct 2008 03:14:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D2C7E2A96AE; Mon, 6 Oct 2008 23:14:17 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8U4oGo1DDTEE; Mon, 6 Oct 2008 23:14:17 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A573C2A96A9; Mon, 6 Oct 2008 23:14:17 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 078CBE7ACD; Mon, 6 Oct 2008 20:14:17 -0700 (PDT) Date: Tue, 07 Oct 2008 03:15:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "tromey@redhat.com" , "gdb-patches@sourceware.org" , Daniel Jacobowitz , Pedro Alves , teawater Subject: Re: [RFA] Reverse Debugging, 4/5 Message-ID: <20081007031416.GA28138@adacore.com> References: <48E3CD40.3070206@vmware.com> <20081006215637.GE21853@adacore.com> <48EA96E6.40504@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48EA96E6.40504@vmware.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00196.txt.bz2 > Erm, yeah, I started to say "I'm open to it", but hey, I just want to > get my patch in! Surely it will be easy enough to change this to a > generic setter later? I don't think I'm the type to let best be the enemy of good, but in this case, changing the function name wouldn't delay your patch all that much. So I would insist in that case that you make the change now rather than later - that way, there's no risk of forgetting. Or are you concerned that choosing the name might turn into a long thread? This being said, I would be totally open to not using the function at all, and setting b->silent directly. This is a well-documented standalone flag and I'm personally fine with accessing it directly. Ideally, I would love for GDB to only use opaque types, but we can always create the accessor routines if/when we decide to make the breakpoint structure opaque (opinions welcome). -- Joel