From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9532 invoked by alias); 6 Oct 2008 19:50:01 -0000 Received: (qmail 9510 invoked by uid 22791); 6 Oct 2008 19:50:00 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Oct 2008 19:49:25 +0000 Received: (qmail 28150 invoked from network); 6 Oct 2008 19:49:23 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 6 Oct 2008 19:49:23 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] Reverse Debugging, 2/5 Date: Mon, 06 Oct 2008 19:50:00 -0000 User-Agent: KMail/1.9.9 Cc: Michael Snyder , Daniel Jacobowitz , teawater References: <48E3CCE2.3000001@vmware.com> In-Reply-To: <48E3CCE2.3000001@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200810062049.55637.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00153.txt.bz2 On Wednesday 01 October 2008 20:17:54, Michael Snyder wrote: > + =C2=A0/* TODO: check target for capability. =C2=A0*/ Can we address this? If you want to be able to query for support, it would be a matter of defining a new qSupported feature. On Wednesday 01 October 2008 20:17:54, Michael Snyder wrote: > - status->kind =3D TARGET_WAITKIND_STOPPED; > - status->value.sig =3D TARGET_SIGNAL_0; > + if (buf[1] =3D=3D '0' && buf[2] =3D=3D '6') > + { > + status->kind =3D TARGET_WAITKIND_NO_HISTORY; > + } > + else > + { > + status->kind =3D TARGET_WAITKIND_STOPPED; > + status->value.sig =3D TARGET_SIGNAL_0; > + } This isn't really an error, it's a defined reply, so it looks a bit strange to me to be using an error number. Is there a reason this can't be reported with a T stop reply and a special "register", like "library" -> TARGET_WAITKIND_LOADED is? AFAICT, nothing else in the remote implementation relies on defined error numbers currently --- annoying at times, but doesn't seem to apply here. + +static enum exec_direction_kind remote_get_execdir (void) Function name on the first column please. +{ + if (remote_debug && info_verbose) + printf_filtered ("remote execdir is %s\n", + remote_execdir =3D=3D EXEC_FORWARD ? "forward" : + remote_execdir =3D=3D EXEC_REVERSE ? "reverse" : + "unknown"); + return remote_execdir; +} This should be made i18n aware. Similarly in remote_set_execdir. No new vCont packets -> no plans on reverse + multi-threading ? :-) --=20 Pedro Alves