From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25780 invoked by alias); 6 Oct 2008 20:30:58 -0000 Received: (qmail 25772 invoked by uid 22791); 6 Oct 2008 20:30:58 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Oct 2008 20:30:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 98BDA2A967F; Mon, 6 Oct 2008 16:30:21 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 9HtRYMkKn0KA; Mon, 6 Oct 2008 16:30:21 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4E9942A967E; Mon, 6 Oct 2008 16:30:21 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1B6F3E7ACD; Mon, 6 Oct 2008 13:30:21 -0700 (PDT) Date: Mon, 06 Oct 2008 20:30:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" , Daniel Jacobowitz , Pedro Alves , teawater Subject: Re: [RFA] Reverse Debugging, 1/5 Message-ID: <20081006203021.GA21853@adacore.com> References: <48E3CCB6.4060501@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48E3CCB6.4060501@vmware.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00158.txt.bz2 > 2008-09-30 Michael Snyder > Target interface for reverse debugging. > * target.h (enum target_waitkind): > Add new wait event, TARGET_WAITKIND_NO_HISTORY. > (enum exec_direction_kind): New enum. > (struct target_ops): New methods to_set_execdir, to_get_execdir. > * target.c (target_get_execdir): New generic method. > (target_set_execdir): Ditto. One of the questions I'm asking myself is why having the get_execdir method? It seems that, once we have called "target_sets_execdir" and it hasn't returned ERROR, core GDB should know what the execution direction is, no? Is there a situation where a round-trip to the target would be necessary? Otherwise, we'll end up with the target code all doing the same thing, which is caching the current value of the same thing. One thing that crossed my mind while thinking about it is whether we want to make this property global to all inferiors or specific to each inferior. Ahem, shall we say global? -- Joel