From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11542 invoked by alias); 28 Sep 2008 16:58:11 -0000 Received: (qmail 11528 invoked by uid 22791); 28 Sep 2008 16:58:10 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 28 Sep 2008 16:57:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6D8D52A96C3; Sun, 28 Sep 2008 12:57:33 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5hwG5uj9qBA4; Sun, 28 Sep 2008 12:57:33 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2AD302A96AD; Sun, 28 Sep 2008 12:57:33 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2FB87E7ACD; Sun, 28 Sep 2008 09:57:31 -0700 (PDT) Date: Sun, 28 Sep 2008 16:58:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: RFA: change K&R to ISO Message-ID: <20080928165731.GG3814@adacore.com> References: <200809270049.06897.pedro@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00549.txt.bz2 > Pedro> OK. Obvious even nowadays? > > I considered that, but I tend to be conservative when applying the > obvious rule. Usually I think I only use it for clearly incorrect > comments, typos, and build breakages. That said, I'm happy to follow > whatever the gdb guidelines actually are. I think it's always better to be more conservative than the opposite, particularly when the change contains a lot of hunks. But on the other hand, my approach (and this is my opinion, not necessarily the opinion of the GDB maintainers) has always been that it's not the end of the world if one small change that was considered obvious by a contributor wasn't so obvious to someone else. It's pretty easy to back out a change after the fact. Back the specific issue of converting from K&R to ISO: The change is fairly mechanical, so the chances of making a mistake are really small. Also, adding a review-before-commit step adds to the "cost" of making the change. Allowing contributors to commit these changes using the obvious rule can only encourage more of these changes. -- Joel