From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5179 invoked by alias); 27 Sep 2008 19:51:45 -0000 Received: (qmail 5168 invoked by uid 22791); 27 Sep 2008 19:51:44 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 27 Sep 2008 19:51:09 +0000 Received: (qmail 1381 invoked from network); 27 Sep 2008 19:51:07 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Sep 2008 19:51:07 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, Tom Tromey Subject: Re: replace typedef_print with a language method Date: Sat, 27 Sep 2008 19:51:00 -0000 User-Agent: KMail/1.9.9 Cc: "Pierre Muller" , "'Eli Zaretskii'" References: <001001c9135b$91014120$b303c360$@u-strasbg.fr> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200809272051.16151.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00541.txt.bz2 Hi Tom, This looks good to me except for the minor comment below. On Wednesday 10 September 2008 18:07:14, Tom Tromey wrote: > @@ -3312,7 +3312,7 @@ print_symbol_info (domain_enum kind, struct symtab > *s, struct symbol *sym, /* Typedef that is not a C++ class */ > if (kind == TYPES_DOMAIN > && SYMBOL_DOMAIN (sym) != STRUCT_DOMAIN) > - typedef_print (SYMBOL_TYPE (sym), sym, gdb_stdout); > + current_language->la_print_typedef (SYMBOL_TYPE (sym), sym, gdb_stdout); For consistency with the other language print methods, could you please add a LA_PRINT_TYPEDEF macro to language.h, and use it instead of calling current_language->la_print_typedef directly? Okay with that change. For extra consistency, I'd be mildly inclined to leave typedef_print in place, similarly to type_print, but I've no strong opinion on that. As a side note, there's a ada_typedef_print function in ada-typeprint.c, but it isn't used anywhere, even pre-your patch. :REVIEWMAIL: Thanks, -- Pedro Alves