From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19315 invoked by alias); 26 Sep 2008 12:55:09 -0000 Received: (qmail 19305 invoked by uid 22791); 26 Sep 2008 12:55:09 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 26 Sep 2008 12:54:30 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D1E1010D00; Fri, 26 Sep 2008 12:54:27 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id B522310CFE; Fri, 26 Sep 2008 12:54:22 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KjCpy-0005ch-5L; Fri, 26 Sep 2008 08:54:22 -0400 Date: Fri, 26 Sep 2008 12:55:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: Joel Brobecker , gdb-patches@sourceware.org, Tobias Burnus , Ulrich Weigand , Jim Blandy , jimb@codesourcery.com Subject: Re: Accessor macro wrappers removal [Re: [patch] static_kind -> bit0, bit1] Message-ID: <20080926125422.GB21287@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , Joel Brobecker , gdb-patches@sourceware.org, Tobias Burnus , Ulrich Weigand , Jim Blandy , jimb@codesourcery.com References: <20080818111120.GE16894@adacore.com> <200808181553.m7IFrG3w005270@d12av02.megacenter.de.ibm.com> <48A59B3C.9050801@net-b.de> <20080818111120.GE16894@adacore.com> <20080907115637.GA12939@host0.dyn.jankratochvil.net> <20080919221221.GA23372@adacore.com> <20080926044309.GA3803@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080926044309.GA3803@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00515.txt.bz2 On Fri, Sep 26, 2008 at 06:43:09AM +0200, Jan Kratochvil wrote: > On Sat, 20 Sep 2008 00:12:21 +0200, Joel Brobecker wrote: > > > Also I do not understand why exist all the macros like this one at all: > > > #define TYPE_MAIN_TYPE(thistype) (thistype)->main_type > > > Why we cannot use it expanded? This way it is always one (or more) > > > "tags"-jump (VIM ctrl-]) indirections while navigating the source files. > > > > Personally, I find them to be very useful to quickly find who is using > > field "main_type" in struct type. > > How does it differ from > grep -- '->main_type\>' *.[ch] > ? "in struct type" is the difference. For main_type it's not too bad. But for e.g. TYPE_FIELD_TYPE you can see the problem; there's lots of things that have a type. If you're looking just for the ones that come from a "struct field", it can be pretty awful to locate them all. -- Daniel Jacobowitz CodeSourcery