From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16010 invoked by alias); 26 Sep 2008 12:52:30 -0000 Received: (qmail 16001 invoked by uid 22791); 26 Sep 2008 12:52:29 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 26 Sep 2008 12:51:50 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id BECB110CF4; Fri, 26 Sep 2008 12:51:47 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 370A210CE6; Fri, 26 Sep 2008 12:51:46 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KjCnR-0005cX-KD; Fri, 26 Sep 2008 08:51:45 -0400 Date: Fri, 26 Sep 2008 12:52:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Jan Kratochvil , gdb-patches@sourceware.org, Tobias Burnus , Ulrich Weigand , Jim Blandy , jimb@codesourcery.com Subject: Re: [patch] static_kind -> bit0, bit1 [Re: [gdb] Fortran dynamic arrays] Message-ID: <20080926125145.GA21287@caradoc.them.org> Mail-Followup-To: Joel Brobecker , Jan Kratochvil , gdb-patches@sourceware.org, Tobias Burnus , Ulrich Weigand , Jim Blandy , jimb@codesourcery.com References: <20080818111120.GE16894@adacore.com> <200808181553.m7IFrG3w005270@d12av02.megacenter.de.ibm.com> <48A59B3C.9050801@net-b.de> <20080818111120.GE16894@adacore.com> <20080907115637.GA12939@host0.dyn.jankratochvil.net> <20080919060336.GD3651@adacore.com> <20080922151909.GA12274@host0.dyn.jankratochvil.net> <20080924191504.GA3613@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080924191504.GA3613@adacore.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00514.txt.bz2 On Wed, Sep 24, 2008 at 12:15:04PM -0700, Joel Brobecker wrote: > Anyway, so the patch is using the TYPE_FIELD_ARTIFICIAL bit to > detect range types where a given bound value cannot be determined. > The patch as it is would work, and I wouldn't object to having it > checked in as a small step forward (with the agreement from at least > one other maintainer). However, I think we can implement this slightly > differently to make it more general. In my opinion, we should go with Jan's patch. I don't think that artificial is a discriminant; it has a clear meaning as a flag and nothing to do with the location or the loc union. What GCC does in this case is have two accessor macros for the same flag bit, so that it is clear at the usage site what is meant by checking the bit. -- Daniel Jacobowitz CodeSourcery