type/main_type/field size [Re: [patch] static_kind -> bit0, bit1]

Jan Kratochvil
2008-10-07T23:22:15Z

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

On Mon, 06 Oct 2008 22:09:28 +0200, Joel Brobecker wrote:
> I think it is kind of ugly, and i tried to think about it for a while,
> but I don't see many possible solutions if we don't want to increase
> the gdbtype struct size.

BTW are there some measurements if sizeof (type / main_type / field) matters?

On Tue, 07 Oct 2008 19:48:53 +0200, Tom Tromey wrote:
> For the lazy psymtab thing I had two related test cases:
>
> 1. Start OO.o writer, then time 'attach'.
> 2. The same, plus time "thread apply all bt full".

FYI I found (on Firefox) the difference of reading full symbols for this
command `thread apply all bt full' is:
valgrind --tool=massif:
mem_heap_B=393798138
mem_heap_B=395820353
== 2MB == only 0.5% size increase (by the attached patch if it is right)

Just `thread apply all bt full' may not be the typical debugging session,
a more representative application / command set would be useful.

Regards,
Jan

[-- Attachment #2: gdb-readneverfull.patch --]
[-- Type: text/plain, Size: 706 bytes --]

--- gdb/dwarf2read.c 30 Sep 2008 16:57:37 -0000 1.285
+++ gdb/dwarf2read.c 7 Oct 2008 20:50:07 -0000
@@ -2432,6 +2432,7 @@ locate_pdi_sibling (struct partial_die_i
static void
dwarf2_psymtab_to_symtab (struct partial_symtab *pst)
{
+return;
/* FIXME: This is barely more than a stub. */
if (pst != NULL)
{
--- gdb/symtab.c 1 Oct 2008 17:25:22 -0000 1.199
+++ gdb/symtab.c 7 Oct 2008 20:50:10 -0000
@@ -1527,6 +1527,8 @@ lookup_symbol_aux_psymtabs (int block_in
psymtab_index, domain))
{
s = PSYMTAB_TO_SYMTAB (ps);
+ if (!s)
+ continue;
bv = BLOCKVECTOR (s);
block = BLOCKVECTOR_BLOCK (bv, block_index);
sym = lookup_block_symbol (block, name, linkage_name, domain);