Re: [patch] static_kind -> bit0, bit1 [Re: [gdb] Fortran dynamic arrays]

Daniel Jacobowitz
2008-09-26T12:52:30Z

On Wed, Sep 24, 2008 at 12:15:04PM -0700, Joel Brobecker wrote:
> Anyway, so the patch is using the TYPE_FIELD_ARTIFICIAL bit to
> detect range types where a given bound value cannot be determined.
> The patch as it is would work, and I wouldn't object to having it
> checked in as a small step forward (with the agreement from at least
> one other maintainer). However, I think we can implement this slightly
> differently to make it more general.

In my opinion, we should go with Jan's patch. I don't think that
artificial is a discriminant; it has a clear meaning as a flag and
nothing to do with the location or the loc union.

What GCC does in this case is have two accessor macros for the same
flag bit, so that it is clear at the usage site what is meant by
checking the bit.

--
Daniel Jacobowitz
CodeSourcery