From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29509 invoked by alias); 19 Sep 2008 14:45:21 -0000 Received: (qmail 29498 invoked by uid 22791); 19 Sep 2008 14:45:20 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 19 Sep 2008 14:44:25 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id C63BD104AC; Fri, 19 Sep 2008 14:44:23 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 8162A1049B; Fri, 19 Sep 2008 14:44:23 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KghDa-0000GT-VA; Fri, 19 Sep 2008 10:44:22 -0400 Date: Fri, 19 Sep 2008 14:45:00 -0000 From: Daniel Jacobowitz To: =?iso-8859-1?Q?Andr=E9_P=F6nitz?= Cc: gdb-patches@sources.redhat.com Subject: Re: gdb sources Message-ID: <20080919144422.GA32108@caradoc.them.org> Mail-Followup-To: =?iso-8859-1?Q?Andr=E9_P=F6nitz?= , gdb-patches@sources.redhat.com References: <200809121713.09226.apoenitz@trolltech.com> <20080912153534.GA13672@caradoc.them.org> <200809191612.23617.apoenitz@trolltech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200809191612.23617.apoenitz@trolltech.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00410.txt.bz2 It looks like you don't have a copyright assignment or employer disclaimer on file. Is that correct? If so, we should sort it out now before you contribute anything larger. On Fri, Sep 19, 2008 at 04:12:14PM +0200, André Pönitz wrote: > Ok. Something tiny attached for starters. It is as harmless as it can be. > I hope this is uncontroversial, but before going further into this > direction I have two related questions: > > 1. How would the prefered way to call, say, xfree on a 'conceptionally const > char *' item look like? Are casts to non-const (void *) acceptable > here? Probably acceptable, but if you know it is allocated by xfree, should it really be returned as const? > 2. Recording every such change in the ChangeLog basically duplicates > the work. Are there any shortcuts available/acceptable? If you have to update the call sites, you can say "all callers updated" or something like that in the changelog entry, though if any of the changes are more than mechanical then it's better to list the complicated ones explicitly. But for just a change to a prototype and a definition, I think the changelog entry is still appropriate. BTW, your changelog is too verbose in another way; there is normally only one starred entry for a file and you can combine similar changes. Like this: * symfile.c (allocate_symtab, allocate_psymtab, free_named_symtabs) (deduce_language_from_filename): Accept a const argument. Please use diff -up for patches; with the default diff arguments, it's impossible to see what you've changed. -- Daniel Jacobowitz CodeSourcery