Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 03/08] multi-process support: remote multi-process 	extensions
Date: Thu, 18 Sep 2008 23:25:00 -0000	[thread overview]
Message-ID: <20080918232439.GE1691@caradoc.them.org> (raw)
In-Reply-To: <200809121751.30596.pedro@codesourcery.com>

On Fri, Sep 12, 2008 at 05:51:30PM +0100, Pedro Alves wrote:
> 2008-09-12  Pedro Alves  <pedro@codesourcery.com>
> 
> 	Implement multi-process extensions.

This looks basically OK to me.  I've got one question, which is not
bad for a patch this size :-)

What about "target remote" vs "target extended-remote"?  Are you
always expected to use target extended-remote to connect to a
multi-process target, and if so, should we enforce that?  Or are
remote and extended-remote supposed to behave the same if the target
is multi-process?

I ask because of the change in remote_detach_1.  If
rs->multi_process_aware is set, we never unregister from
the target.  But we call target_mourn_inferior which will unpush the
remote target in that case.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-09-18 23:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-12 15:40 Pedro Alves
2008-09-12 15:43 ` Christopher Faylor
2008-09-12 16:10 ` Eli Zaretskii
2008-09-12 16:52   ` Pedro Alves
2008-09-18 23:25     ` Daniel Jacobowitz [this message]
2008-09-19 15:32       ` Pedro Alves
2008-09-19 16:30         ` Daniel Jacobowitz
2008-09-19 22:25           ` Pedro Alves
2008-09-22 13:29             ` [RFA 03/08] multi-process support: remote multi-process ?extensions Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080918232439.GE1691@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox