From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21876 invoked by alias); 18 Sep 2008 19:39:42 -0000 Received: (qmail 21860 invoked by uid 22791); 18 Sep 2008 19:39:40 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 18 Sep 2008 19:39:02 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 87FE110004; Thu, 18 Sep 2008 19:38:59 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 6C62810003; Thu, 18 Sep 2008 19:38:59 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KgPL8-0006s0-Qb; Thu, 18 Sep 2008 15:38:58 -0400 Date: Thu, 18 Sep 2008 19:39:00 -0000 From: Daniel Jacobowitz To: "H.J. Lu" Cc: GDB Subject: Re: PATCH: Extend gdb remote protocol for AVX Message-ID: <20080918193858.GA26337@caradoc.them.org> Mail-Followup-To: "H.J. Lu" , GDB References: <20080918172728.GA12703@lucon.org> <20080918183402.GA22646@caradoc.them.org> <6dc9ffc80809181203g3e7b67ccm35bfc86f80c27fc2@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6dc9ffc80809181203g3e7b67ccm35bfc86f80c27fc2@mail.gmail.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00392.txt.bz2 On Thu, Sep 18, 2008 at 12:03:11PM -0700, H.J. Lu wrote: > On Thu, Sep 18, 2008 at 11:34 AM, Daniel Jacobowitz > wrote: > > On Thu, Sep 18, 2008 at 10:27:28AM -0700, H.J. Lu wrote: > >> b. If remote target supports AVX: > >> i. Don't send xmlarch. > >> ii. Replace 128bit xmm registers with 256bit ymm registers in > >> the g/G packet. > >> iii. Gdb will auto-detect SSE unit on remote target, based on the > >> the g/G packet size. > > > > Just a general note: I would much prefer you use the XML mechanism for > > this, either by an architecture name or a property or an explicit > > register description, than add more guesses to the g/G packet checks; > > they're a heuristic for existing remote targets. > > > > I tried adding xmlarch to regformats files. But I don't want to add new > xmlarch entry for AVX since I had to create a new arch entry in BFD for it. It > isn't necessary for this purpose. If I use the existing xmlarch, like > i386:x86-64, it will match regformats/reg-x86-64.dat. Using > the g/G packet size allows me not to add a new arch entry in BFD. > Is there a way to do it with XML without changing BFD? Yes, either of the other two options I described. MIPS uses both of them; search for PROPERTY_GP32 or tdesc_has_registers. -- Daniel Jacobowitz CodeSourcery