Re: PATCH: Extend gdb remote protocol for AVX

Mark Kettenis
2008-10-29T07:41:29Z

> Date: Tue, 28 Oct 2008 19:15:51 -0700
> From: "H.J. Lu" <hjl.tools@gmail.com>
>
> On Tue, Oct 28, 2008 at 9:26 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> >> Date: Tue, 28 Oct 2008 10:10:21 -0400
> >> From: Daniel Jacobowitz <drow@false.org>
> >>
> >> On Mon, Oct 27, 2008 at 10:58:36PM -0700, H.J. Lu wrote:
> >> > Are there any objections to my AVX patch?
> >>
> >> There were objections - just read the thread you are replying to. If
> >> you have not changed the patch, then there are still objections.
> >
> > I also think it would be good to seperate out the changes to GDB's
> > internal register file from the extensions you want to make to the
>
> Here is the patch to extend gdb remote protocol for AVX.
>
> > remote protocol. And I'd really like to see how an implementation of
> > i387_supply_xsave() and i387_collect_xsave() would look in that
> > context.
>
> It is hard to implement them without an OS running on AVX
> H/W. At this moment, we only need to define a remote protocol
> for AVX. We can work on native AVX support when H/W is
> available.

No we cannot. You're making changes to how GDB deals internally with
these registers. You need take native AUVX support into account when
you want to change those too.