From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2320 invoked by alias); 15 Sep 2008 02:24:05 -0000 Received: (qmail 2311 invoked by uid 22791); 15 Sep 2008 02:24:04 -0000 X-Spam-Check-By: sourceware.org Received: from hiauly1.hia.nrc.ca (HELO hiauly1.hia.nrc.ca) (132.246.100.193) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 15 Sep 2008 02:23:13 +0000 Received: by hiauly1.hia.nrc.ca (Postfix, from userid 1000) id 3E9254DCB; Sun, 14 Sep 2008 22:23:10 -0400 (EDT) Subject: Re: [PATCH] Fix hppa_linux_sigtramp_frame_unwind_cache To: dave@hiauly1.hia.nrc.ca (John David Anglin) Date: Mon, 15 Sep 2008 02:24:00 -0000 From: "John David Anglin" Cc: randolph@tausq.org, gdb-patches@sourceware.org In-Reply-To: from "John David Anglin" at Sep 13, 2008 11:47:21 pm X-Mailer: ELM [version 2.4 PL25] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20080915022311.3E9254DCB@hiauly1.hia.nrc.ca> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00329.txt.bz2 > No, you are correct. The long long field will be aligned at an 8-byte > boundary. I will keep the pad. Committed the following after retesting. Dave -- J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602) 2008-09-14 John David Anglin * hppa-linux-tdep.c (hppa_linux_sigtramp_frame_unwind_cache): Record HPPA_IPSW_REGNUM and HPPA_SAR_REGNUM values. Index: hppa-linux-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/hppa-linux-tdep.c,v retrieving revision 1.32 diff -u -3 -p -r1.32 hppa-linux-tdep.c --- hppa-linux-tdep.c 14 Sep 2008 14:08:42 -0000 1.32 +++ hppa-linux-tdep.c 15 Sep 2008 00:50:52 -0000 @@ -227,7 +227,8 @@ hppa_linux_sigtramp_frame_unwind_cache ( /* Skip sc_flags. */ scptr += 4; - /* GR[0] is the psw, we don't restore that. */ + /* GR[0] is the psw. */ + info->saved_regs[HPPA_IPSW_REGNUM].addr = scptr; scptr += 4; /* General registers. */ @@ -237,7 +238,7 @@ hppa_linux_sigtramp_frame_unwind_cache ( scptr += 4; } - /* Pad. */ + /* Pad to long long boundary. */ scptr += 4; /* FP regs; FP0-3 are not restored. */ @@ -262,6 +263,8 @@ hppa_linux_sigtramp_frame_unwind_cache ( info->saved_regs[HPPA_PCOQ_TAIL_REGNUM].addr = scptr; scptr += 4; + info->saved_regs[HPPA_SAR_REGNUM].addr = scptr; + info->base = get_frame_register_unsigned (this_frame, HPPA_SP_REGNUM); return info;