From: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
To: gdb-patches@sourceware.org
Cc: randolph@tausq.org
Subject: [PATCH] Fix hppa_linux_sigtramp_frame_unwind_cache
Date: Sat, 13 Sep 2008 23:58:00 -0000 [thread overview]
Message-ID: <20080913235740.ADEF94E6A@hiauly1.hia.nrc.ca> (raw)
The main fix in this patch is to remove the pad increment of scptr. As
far as I know, there is no pad field in the sigcontext struct between the
general registers and the floating point registers.
I also recorded the PSW and SAR registers. It might be a mistake to record
the PSW value, but I believe the SAR register definitely needs to be recorded.
Somewhat tested on hppa-linux but the gdb testsuite crashes 2.6.19.22.
Ok?
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)
2008-09-13 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
* hppa-linux-tdep.c (hppa_linux_sigtramp_frame_unwind_cache): Record
HPPA_IPSW_REGNUM and HPPA_SAR_REGNUM values. Remove pad increment.
Index: hppa-linux-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/hppa-linux-tdep.c,v
retrieving revision 1.31
diff -u -3 -p -r1.31 hppa-linux-tdep.c
--- hppa-linux-tdep.c 21 Aug 2008 13:19:18 -0000 1.31
+++ hppa-linux-tdep.c 13 Sep 2008 22:51:35 -0000
@@ -227,7 +229,8 @@ hppa_linux_sigtramp_frame_unwind_cache (
/* Skip sc_flags. */
scptr += 4;
- /* GR[0] is the psw, we don't restore that. */
+ /* GR[0] is the psw. */
+ info->saved_regs[HPPA_IPSW_REGNUM].addr = scptr;
scptr += 4;
/* General registers. */
@@ -237,9 +240,6 @@ hppa_linux_sigtramp_frame_unwind_cache (
scptr += 4;
}
- /* Pad. */
- scptr += 4;
-
/* FP regs; FP0-3 are not restored. */
scptr += (8 * 4);
@@ -262,6 +262,9 @@ hppa_linux_sigtramp_frame_unwind_cache (
info->saved_regs[HPPA_PCOQ_TAIL_REGNUM].addr = scptr;
scptr += 4;
+ info->saved_regs[HPPA_SAR_REGNUM].addr = scptr;
+ scptr += 4;
+
info->base = get_frame_register_unsigned (this_frame, HPPA_SP_REGNUM);
return info;
next reply other threads:[~2008-09-13 23:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 23:58 John David Anglin [this message]
2008-09-14 2:44 ` Randolph Chung
2008-09-14 3:47 ` John David Anglin
[not found] <no.id>
2008-09-15 2:24 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080913235740.ADEF94E6A@hiauly1.hia.nrc.ca \
--to=dave@hiauly1.hia.nrc.ca \
--cc=gdb-patches@sourceware.org \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox