From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3389 invoked by alias); 13 Sep 2008 22:21:09 -0000 Received: (qmail 3375 invoked by uid 22791); 13 Sep 2008 22:21:08 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 13 Sep 2008 22:20:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 472A32A96F5 for ; Sat, 13 Sep 2008 18:20:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5Je3lVpmTQUL for ; Sat, 13 Sep 2008 18:20:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0F2332A96EF for ; Sat, 13 Sep 2008 18:20:25 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B7715E7ACD; Sat, 13 Sep 2008 15:20:22 -0700 (PDT) Date: Sat, 13 Sep 2008 22:21:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFA/commit/dwarf] Create partial symbols for nested subprograms Message-ID: <20080913222022.GJ3714@adacore.com> References: <20080910201959.GC10133@adacore.com> <20080910203437.GA26162@caradoc.them.org> <20080911175422.GS12222@adacore.com> <20080911183730.GA17809@caradoc.them.org> <20080911215224.GT12222@adacore.com> <20080913151406.GA6583@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080913151406.GA6583@caradoc.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00299.txt.bz2 > > 2008-09-11 Joel Brobecker > > > > * dwarf2read.c (add_partial_subprogram): New procedure. > > (scan_partial_symbols): Use it. > > (load_partial_dies): Read in children of subprogram and lexical > > blocks for Ada compilation units. > > > > Tested on x86-linux, no regression. > > Yes, this is OK. I agree it's the right compromise, at least for the > moment. Thanks! Now checked in. -- Joel