From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22590 invoked by alias); 13 Sep 2008 15:14:49 -0000 Received: (qmail 22580 invoked by uid 22791); 13 Sep 2008 15:14:48 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 13 Sep 2008 15:14:09 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id A4958104C0; Sat, 13 Sep 2008 15:14:07 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 7E188104BF; Sat, 13 Sep 2008 15:14:07 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KeWp4-0001ik-Ix; Sat, 13 Sep 2008 11:14:06 -0400 Date: Sat, 13 Sep 2008 15:14:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit/dwarf] Create partial symbols for nested subprograms Message-ID: <20080913151406.GA6583@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20080910201959.GC10133@adacore.com> <20080910203437.GA26162@caradoc.them.org> <20080911175422.GS12222@adacore.com> <20080911183730.GA17809@caradoc.them.org> <20080911215224.GT12222@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080911215224.GT12222@adacore.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00288.txt.bz2 On Thu, Sep 11, 2008 at 02:52:24PM -0700, Joel Brobecker wrote: > > I usually use 'gdb -batch foo.exe' to time reading partial symbols, > > and 'gdb -readnow -batch foo.exe' to time full symbols (only partial > > symbols are at issue here). > > And use the "time" command to measure the time elapsed? Somehow, > I got reported user times and total times that fluctuated a little > more than when I used the --statistics. Yes, I have a script to time things repeatedly and give me average/stddev. > Sure! Is that what you had in mind? > > 2008-09-11 Joel Brobecker > > * dwarf2read.c (add_partial_subprogram): New procedure. > (scan_partial_symbols): Use it. > (load_partial_dies): Read in children of subprogram and lexical > blocks for Ada compilation units. > > Tested on x86-linux, no regression. Yes, this is OK. I agree it's the right compromise, at least for the moment. -- Daniel Jacobowitz CodeSourcery