Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/RFC] libdecnumber/gstdint.h is back :-(
Date: Sat, 13 Sep 2008 14:14:00 -0000	[thread overview]
Message-ID: <20080913141335.GA3005@caradoc.them.org> (raw)
In-Reply-To: <20080913050011.GA3727@adacore.com>

On Fri, Sep 12, 2008 at 10:00:11PM -0700, Joel Brobecker wrote:
> Hello,
> I looked at the C90 draft that I have, and it seems to be saying
> that, whether you use angled brackets or double quotes in your include
> syntax, the way the file is located is implementation defined.
> So, no help there. This needs to be confirmed, but it looks like
> GCC will try to find the include file starting from the same directory
> as the file including it when double quotes are used. In other words,
> when the following directive is used from ../libdecnumber/decContext.h
> 
>    #include "gstdint.h"
> 
> GCC will first try ../libdecnumber/gstdint.h, not ./gstdint.h.
> This defeats the purpose of the gstdint.h that we introduced in
> the gdb subdirectory.

Why does ../libdecnumber/gstdint.h exist?  Is it because you're
configuring in the source directory, and if so can we just tell people
not to do that?

Another option would be to add a check for _GL_STDINT_H to
libdecnumber; I suspect they would not mind.

> What occured to me while thinking about all this is that the
> root of the problem is that we have two incompatible files that
> should be identical in practice. Since we are always building
> libdecnumber, can we use libdecnumber's gstdint.h and ditch
> gnulib's stdint.h?

This could be a problem if we pulled in gnulib modules that
include <stdint.h> from a replacement header.  We already use
it in the building of gnulib (str-two-way.h).

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-09-13 14:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-13  5:01 Joel Brobecker
2008-09-13 14:14 ` Daniel Jacobowitz [this message]
2008-09-13 17:08   ` Joel Brobecker
2008-09-13 17:56     ` Daniel Jacobowitz
2008-09-14  6:48       ` Joel Brobecker
2008-09-14 16:04         ` Joel Brobecker
2008-09-14 17:17           ` Daniel Jacobowitz
2008-09-16 18:22             ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080913141335.GA3005@caradoc.them.org \
    --to=drow@false.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox