Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [autodeps] gnu-nat, autogenerated files
Date: Fri, 12 Sep 2008 05:06:00 -0000	[thread overview]
Message-ID: <20080912050501.GC3714@adacore.com> (raw)
In-Reply-To: <200809101948.18370.pedro@codesourcery.com>

> Hmmmm, looking at the docs you pointed below, I believe NAT_GENERATED_FILES
> is more correct.  These files shouldn't be generated when building a cross
> debugger hosted on the hurd.  I've made that change, hope it's OK.

That makes sense.

> Hmmm, errmmm, I don't know what to do here.  :-)

Eli is the documentation guru, I'll let him decide :).

> TM_CLIBS and TM_CDEPS also looks like looking for garbage collection.

Yes - If I'm not mistaken, we have finally gotten rid of tm files.
So they can definitely go.

> 2008-09-10  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* Makefile.in (generated_files): Add $(NAT_GENERATED_FILES).
> 	* config/i386/i386gnu.mh (NAT_GENERATED_FILES): New.

This part is OK.

> gdb/doc/
> 2008-09-10  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* gdbint.texinfo (Native Debugging): Mention NAT_GENERATED_FILES.

That part needs to be reviewed by Eli.

> +
> +NAT_GENERATED_FILES = notify_S.h notify_S.c process_reply_S.h process_reply_S.c \

Just a very minor comment: I wonder if you might have exceeded 80 chars
on this line.

-- 
Joel


  reply	other threads:[~2008-09-12  5:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-09 15:07 Pedro Alves
2008-09-09 16:09 ` Tom Tromey
2008-09-09 16:18   ` Daniel Jacobowitz
2008-09-09 16:28     ` Tom Tromey
2008-09-10 18:01 ` Joel Brobecker
2008-09-10 18:13   ` Daniel Jacobowitz
2008-09-10 18:49   ` Pedro Alves
2008-09-12  5:06     ` Joel Brobecker [this message]
2008-09-12  9:10       ` Eli Zaretskii
2008-09-12 10:44         ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080912050501.GC3714@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox