From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16091 invoked by alias); 10 Sep 2008 20:35:19 -0000 Received: (qmail 16081 invoked by uid 22791); 10 Sep 2008 20:35:18 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 10 Sep 2008 20:34:39 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 2388A10196; Wed, 10 Sep 2008 20:34:38 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 0DDD310195; Wed, 10 Sep 2008 20:34:37 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KdWOb-0006sH-Eu; Wed, 10 Sep 2008 16:34:37 -0400 Date: Wed, 10 Sep 2008 20:35:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit/dwarf] Create partial symbols for nested subprograms Message-ID: <20080910203437.GA26162@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20080910201959.GC10133@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080910201959.GC10133@adacore.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00226.txt.bz2 On Wed, Sep 10, 2008 at 01:19:59PM -0700, Joel Brobecker wrote: > I stumbled on this because I am about to remove the piece of code > mentioned above (in ada_lookup_symbol_list), as it introduces > a pretty significant performance penalty - I will post a separate > patch with more details later on. But at the same time, I think > it is important by itself, as I want the partial symtab and full > symtab to be consistent. > > 2008-09-10 Joel Brobecker > > * dwarf2read.c (add_partial_subprogram): New procedure. > (scan_partial_symbols): Use it. > (load_partial_dies): Read in children of subprogram and lexical > blocks. :-( Do you have any performance data for GDB startup with this change? Not that I see any useful way around it, if subprograms really can be children of lexical blocks. But it's going to cause us to read in a ton more DIEs, including all scopes and local variables. The lexical block check won't work as is; we'd walk children of lexical blocks, except we'll never read one in the first place. See the skip_one_die call earlier in load_partial_dies. -- Daniel Jacobowitz CodeSourcery