From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29543 invoked by alias); 10 Sep 2008 09:43:15 -0000 Received: (qmail 29529 invoked by uid 22791); 10 Sep 2008 09:43:14 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 10 Sep 2008 09:42:28 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m8A9fGHX111678 for ; Wed, 10 Sep 2008 09:41:16 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m8A9fF9n1998922 for ; Wed, 10 Sep 2008 11:41:15 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m8A9fBHL006501 for ; Wed, 10 Sep 2008 11:41:11 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m8A9fBR4005671; Wed, 10 Sep 2008 11:41:11 +0200 Message-Id: <200809100941.m8A9fBR4005671@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 10 Sep 2008 11:40:45 +0200 Subject: Re: [rfc][00/37] Eliminate builtin_type_ macros To: brobecker@adacore.com (Joel Brobecker) Date: Wed, 10 Sep 2008 09:43:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20080910061720.GL12222@adacore.com> from "Joel Brobecker" at Sep 09, 2008 11:17:20 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00207.txt.bz2 Joel Brobecker wrote: > Sure! I don't know what this didn't cross my mind earlier, I guess > I was in a bit of a crunch... Will do that tomorrow (I'm also planning > on submitting a bunch of patches tomorrow as well, if things go as > planned - so that'll be a good time for that). OK, thanks! > It was on top of your patch - If I am not mistaken, it should apply > cleanly after you apply yours. I did, however, generate the patch > against AdaCore's gdb-head (which is a merge between our changes > and nearly-top-of-fsf-tree) to which I applied your patch. So there > might indeed be some differences that would cause a conflict; I just > don't see any, right now. Your version has: > > > + return value_from_longest (builtin_type_int32, > > > TARGET_CHAR_BIT * TYPE_LENGTH (type)); which causes the problem with the re-used "type" variable. The current gdb-head version has: > > return value_from_longest (builtin_type_int, > > TARGET_CHAR_BIT > > * TYPE_LENGTH (value_type (arg1))); instead, where this problem does not occur. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com