From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12558 invoked by alias); 10 Sep 2008 06:09:47 -0000 Received: (qmail 12548 invoked by uid 22791); 10 Sep 2008 06:09:46 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 10 Sep 2008 06:09:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 577842A965A; Wed, 10 Sep 2008 02:09:10 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id YhcTv4Sjwl39; Wed, 10 Sep 2008 02:09:10 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 233412A9650; Wed, 10 Sep 2008 02:09:10 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 01966E7ACD; Wed, 10 Sep 2008 08:09:07 +0200 (CEST) Date: Wed, 10 Sep 2008 06:09:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc][19/37] Eliminate builtin_type_ macros: Ada range type handling Message-ID: <20080910060907.GK12222@adacore.com> References: <20080909220747.GJ12222@adacore.com> <200809092230.m89MUKcR000554@d12av02.megacenter.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200809092230.m89MUKcR000554@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00205.txt.bz2 > So I guess your original proposal to use the range type itself is > the simplest solution. Implemented by the patch below. Agreed. > ChangeLog: > > * ada-lang.c (ada_array_length): Use builtin_type_int32 instead > of builtin_type_int. > (ada_evaluate_subexp) [UNOP_IN_RANGE]: Use operand range type > instead of builtin_type_int. I think we can commit this independently of the rest, right? -- Joel