From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1657 invoked by alias); 9 Sep 2008 22:32:01 -0000 Received: (qmail 1647 invoked by uid 22791); 9 Sep 2008 22:32:01 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.17.162) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 Sep 2008 22:31:13 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.1/8.13.1) with ESMTP id m89MVAVU002873 for ; Tue, 9 Sep 2008 22:31:10 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m89MVAVC2334928 for ; Wed, 10 Sep 2008 00:31:10 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m89MVAPl000880 for ; Wed, 10 Sep 2008 00:31:10 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m89MVAmf000877; Wed, 10 Sep 2008 00:31:10 +0200 Message-Id: <200809092231.m89MVAmf000877@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 10 Sep 2008 00:31:10 +0200 Subject: Re: [rfc] Fix removing breakpoint from shared library race To: brobecker@adacore.com (Joel Brobecker) Date: Tue, 09 Sep 2008 22:32:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20080909204318.GG12222@adacore.com> from "Joel Brobecker" at Sep 09, 2008 01:43:18 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00201.txt.bz2 Joel Brobecker wrote: > > This is the situation that my patch attempts to address, by having the > > remove_breakpoints not fail. At some later point, either when GDB > > actually gets to process the solib event, or when GDB tries to > > re-insert the breakpoints, GDB will properly recognize that the > > library has been unloaded and sets the state to solib_disabled. > > Just wanted to let you know that you patch makes complete sense to me. > As you pointed out in your first message, this is in fact very similar > to what we do in insert_bp_location. Thanks for looking at this patch! Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com