Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Fix removing breakpoint from shared library race
Date: Tue, 09 Sep 2008 20:43:00 -0000	[thread overview]
Message-ID: <20080909204318.GG12222@adacore.com> (raw)
In-Reply-To: <200808181414.m7IEEZtO010275@d12av02.megacenter.de.ibm.com>

Ulrich,

Sorry for the late reply, but:

> This is the situation that my patch attempts to address, by having the
> remove_breakpoints not fail.  At some later point, either when GDB
> actually gets to process the solib event, or when GDB tries to
> re-insert the breakpoints, GDB will properly recognize that the
> library has been unloaded and sets the state to solib_disabled.

Just wanted to let you know that you patch makes complete sense to me.
As you pointed out in your first message, this is in fact very similar
to what we do in insert_bp_location.

-- 
Joel


  reply	other threads:[~2008-09-09 20:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13 20:36 Ulrich Weigand
2008-08-18 11:47 ` Joel Brobecker
2008-08-18 14:15   ` Ulrich Weigand
2008-09-09 20:43     ` Joel Brobecker [this message]
2008-09-09 22:32       ` Ulrich Weigand
2008-08-26 17:43 ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080909204318.GG12222@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox