From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5598 invoked by alias); 5 Sep 2008 22:56:56 -0000 Received: (qmail 5588 invoked by uid 22791); 5 Sep 2008 22:56:55 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 Sep 2008 22:56:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BE1892A971D; Fri, 5 Sep 2008 18:56:13 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id sSpFr2Piya4J; Fri, 5 Sep 2008 18:56:13 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 895892A971A; Fri, 5 Sep 2008 18:56:13 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7E11BE7ACD; Sat, 6 Sep 2008 00:56:11 +0200 (CEST) Date: Fri, 05 Sep 2008 22:56:00 -0000 From: Joel Brobecker To: uweigand@de.ibm.com Cc: gdb-patches@sourceware.org Subject: Re: [rfc][13/37] Eliminate builtin_type_ macros: Update EVAL_SKIP dummy return type Message-ID: <20080905225611.GG15267@adacore.com> References: <20080831175045.128504000@de.ibm.com> <20080831175124.866908000@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080831175124.866908000@de.ibm.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00114.txt.bz2 > As the actual type doesn't really matter, this patch changes that > to use builtin_type_int8 instead. (maybe I am answering prematurely since I haven't read the other patches, but I have to answer now, or I'll probably forget by the time I reach the last patch). I understand how builtin_type_int8 is architecture neutral, and thus allows us to get rid of the dependency on the gdbarch. No dispute on the actual patch. But the patch really made me think that we really ought to have a procedure that returns a dummy value for the EVAL_SKIP case. That way, we don't have to remember that we should be using an arch-neutral type such as builtin_type_int8. On another related note, the "goto nosideret" seems to be misused to me. We seem to always have: goto nosideret; [...] nosideret: return value_from_longest (builtin_type_long, (LONGEST) 1); If we have a value_dummy() function, we can replace all gotos with a "return value_dummy ()", and get rid of the label. I think it will be more readable. This can be done as a followup patch, though... -- Joel