From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26458 invoked by alias); 5 Sep 2008 13:11:49 -0000 Received: (qmail 26437 invoked by uid 22791); 5 Sep 2008 13:11:47 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 Sep 2008 13:11:13 +0000 Received: (qmail 21243 invoked from network); 5 Sep 2008 13:11:11 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Sep 2008 13:11:11 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch, rfc] Re: target_find_description question Date: Fri, 05 Sep 2008 13:11:00 -0000 User-Agent: KMail/1.9.9 Cc: "Ulrich Weigand" , drow@false.org References: <200809042359.m84NxTYO018519@d12av02.megacenter.de.ibm.com> In-Reply-To: <200809042359.m84NxTYO018519@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200809051411.11686.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00097.txt.bz2 On Friday 05 September 2008 00:59:29, Ulrich Weigand wrote: > In addition, this has some further benefits: > - We can now properly handle cases where the inferior dies while in the > shell (the FIXME in the old startup_inferior code) > - The treat_exec_as_sigtrap argument to handle_inferior_event is no longer > used and could be removed (not part of this patch) Of course, a specific stop_soon flag for startup/going through the shell would also make it possible to do this in handle_inferior_event, but indeed, it would be more complicated. > Tested on amd64-linux with no regressions. > > What do you think? I like it. Notice that there are fork-child targets that handle this even at a lower level, within target_wait (see gnu-nat.c). -- Pedro Alves